Hi @thomas-kl1. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.
❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

@magento run all tests

@magento run all tests

@magento run Unit Tests, Static Tests, Integration Tests

@magento run all tests

@magento create issue

@magento run all tests

@engcom-Charlie Regarding the integration tests failures:

I can't fix the B2B/EE tests, in order to fix them you should replace the getValue par isSetFlag method when looking for the following configs:

• general/single_store_mode/enabled
• web/url/use_store

You should also look for default and not by scope for web/url/use_store.

@magento run all tests

@magento run Database Compare

@magento run Functional Tests CE, Functional Tests B2B

@thomas-kl1 thank you for your contribution!

Currently we are looking into priority PRs from Community Dashboard, we will surely pick this PR as per the priority.

Thank you!

@magento run all tests

@magento run all tests

@magento run Functional Tests B2B, Functional Tests CE, Functional Tests EE

Hello @engcom-Hotel Could you please review the changes. I have fixed the failing integration tests. The failed functional tests seems to flaky and have known JIRAs for them.

Hence moving this PR for review.

@magento run all tests

@magento run Functional Tests B2B, Functional Tests CE, Functional Tests EE, Unit Tests

@magento run all tests

✔️ QA Passed

Preconditions:
Install fresh 2.4-develop

Steps to reproduce:

1. Check the core files where "Add Store Code to Urls" setting fetched using current scope store.

Before: ❌
As we can see in the screenshot that getValue() function has been called to get the value of configuration. This function passes the scope as a store scope where as the configuration says that its a global setting hence the scope should be default.

After: ✔️

In this PR the getValue() has been replaced by isSetFlag() which is using default scope to retrive the value. Also, it returns boolean result. This PR addresses this issue by ensuring that the setting is retrieved using the default/global scope

The builds are failed hence moving this PR in Extended Testing

@magento run Functional Tests B2B, Functional Tests CE, Functional Tests EE

The consistent failures in Functional B2B are known issues and JIRA is open for the same. The other failures are inconsistent and flaky. They neither part of the PR nor failing because of the PR changes

Build 1: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/40065/e7a9d51de4f15fbe0e4bf35ede579fd1/Functional/allure-report-b2b/index.html#categories/21465133e2db886cc777a8a85e4fd039/7fac23bb63d6099f/

Build 2: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/40065/952936cbfd72f19966bab2ff7d5e38cb/Functional/allure-report-b2b/index.html#categories/e40e613a1322e9aefb5d868a36a83a73/cd14f16f829d24e5/

Known Issues:
AdminStagingDashboardProvideAbilityToViewEditForUpdatesWithCartPriceRuleTest ACQE-8610
AssignCustomOrderStatusNotVisibleOnStorefrontTest ACQE-8490

The consistent failure in Functional CE is known issue and JIRA is open for the same. The other failures are inconsistent and flaky. They neither part of the PR nor failing because of the PR changes

Build 1: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/40065/07049bb0252ad31df782ab5237e005db/Functional/allure-report-ce/index.html#categories/8fb3a91ba5aaf9de24cc8a92edc82b5d

Build 2: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/40065/fccaef6b743ea8a0c258e8bcc6900805/Functional/allure-report-ce/index.html#categories/8fb3a91ba5aaf9de24cc8a92edc82b5d

Known Issue: StorefrontDeleteSimpleAndVirtualProductFromMiniShoppingCartTest ACQE-8560

The consistent failures in Functional EE are known issues and JIRA is open for the same. The other failures are inconsistent and flaky. They neither part of the PR nor failing because of the PR changes

Build 1: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/40065/6eafd3c685fdcdb43e65223aa573e7e2/Functional/allure-report-ee/index.html#categories/8fb3a91ba5aaf9de24cc8a92edc82b5d

Build 2: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/40065/8b6896284a44b91e5e7b06168e129a67/Functional/allure-report-ee/index.html#categories/8fb3a91ba5aaf9de24cc8a92edc82b5d

Known Issues:
AdminStagingDashboardProvideAbilityToViewEditForUpdatesWithCartPriceRuleTest ACQE-8610
AssignCustomOrderStatusNotVisibleOnStorefrontTest ACQE-8490

Hence moving this PR in Merge In Progress.